chore: SSE bug fixes #639
Merged
chore: SSE bug fixes #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/in-app-sse #639 +/- ##
========================================================
+ Coverage 67.85% 68.30% +0.44%
- Complexity 748 760 +12
========================================================
Files 142 142
Lines 4303 4303
Branches 580 580
========================================================
+ Hits 2920 2939 +19
+ Misses 1165 1141 -24
- Partials 218 223 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
Build available to test |
📏 SDK Binary Size Comparison Report
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistModalActivity.kt
Outdated
Show resolved
Hide resolved
|
|
mrehan27
approved these changes
Jan 12, 2026
Contributor
mrehan27
left a comment
mrehan27
left a comment
There was a problem hiding this comment.
Looks good overall. Just two questions before we merge this:
- Do we also need to add message equality check in subscriber (
subscribeToAttributes), or is adding it inonDestroysufficient? - Can we add some tests to cover these changes?
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistModalActivity.kt
Outdated
Show resolved
Hide resolved
mahmoud-elmorabea
force-pushed
the
sse-wrap-up
branch
from
7047457 to
7726fa2
Compare
|
|
mahmoud-elmorabea
force-pushed
the
sse-wrap-up
branch
from
7726fa2 to
e795523
Compare
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This PR fixes an issue for in-app Android. Sometimes when there are multiple messages the
GistModalActivityanimation takes longer than the processor to update the state. In which case, the activity dismisses the wrong message.onDestroyof old activity runs and grabs the current message -> which is now message 2Dismisses it as per this
This is not really related to SSE but it's more apparent because SSE shows subsequent messages faster.
The fix
GistModalActivityis created, it holds on to the message it was created to showonDestroyruns, we make sure not to call dismiss unless our message is being shownNote
Fix race condition in modal dismissal
GistModalActivity: trackactivityMessageand inonDestroydispatchDismissMessageonly if itsqueueIdmatches the currently displayed message; persistent messages dismiss withshouldLog = false. Minor refactor:isPersistentMessage(message: Message?).InAppMessagingMiddlewares: after dismissal, gate queue processing bystore.state.shouldUseSse(wassseEnabled).InAppMessagingManager.Written by Cursor Bugbot for commit e795523. This will update automatically on new commits. Configure here.